Make [Thread.id] and [Thread.self] [noalloc].#196
Make [Thread.id] and [Thread.self] [noalloc].#196cgaebel wants to merge 2 commits intoocaml:trunkfrom
Conversation
otherlibs/threads/thread.ml
Outdated
There was a problem hiding this comment.
I'm just picky but could you remove the newline, please? It is not anymore separating exported and not exported external.
|
Good, and no other functions of the module seems to satisfy the noalloc requirements. I'm just wondering if we should annotate all the C functions that are declared |
|
@bobot good idea; we could even have it as a silent attribute (defined to be nothing) to use just after |
51e3169 to
05a0a19
Compare
These functions are called every tick of the Async scheduler, and are the only remaining calls to [caml_c_call] every cycle. It would be nice to remove them, especially since these functions don't allocate.
05a0a19 to
58593a6
Compare
|
Shouldn't this patch be editing otherlibs/systhreads/, not otherlibs/threads ? |
|
I've added the changes to otherlibs/systhreads. Why does the patch not apply to otherlibs/threads, also? @mshinwell |
|
Merged in trunk, thanks for the patch! (My understanding is that applying the change to both |
These functions are called every tick of the Async scheduler, and
are the only remaining calls to [caml_c_call] every cycle. It would
be nice to remove them, especially since these functions don't
allocate.