restore the specialized error path for record patterns#1872
Merged
gasche merged 1 commit intoocaml:trunkfrom Jul 1, 2018
Merged
restore the specialized error path for record patterns#1872gasche merged 1 commit intoocaml:trunkfrom
gasche merged 1 commit intoocaml:trunkfrom
Conversation
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores a specialized error path for mixed record labels in record patterns:
on the expression side, mixing record labels (from different record types) inside a record expression
yields a specialized error message:
Contrarily, the error message for erroneous record patterns
is the generic one
This difference is due to a small exception imbroglio: the label typing code was expecting an
Unifyexception after a call tounify_pat_typesbutunify_pat_typescatchesUnifyexception by itself and transform them intoPattern_type_clasherrors.