Race condition when building ocamlbuild with massive parallelism#179
Closed
let-def wants to merge 1 commit intoocaml:trunkfrom
Closed
Race condition when building ocamlbuild with massive parallelism#179let-def wants to merge 1 commit intoocaml:trunkfrom
let-def wants to merge 1 commit intoocaml:trunkfrom
Conversation
Member
|
Merged, thanks. it's well-known that the Makefile are a bit flaky regarding parallelism, and the occasional fix is welcome. (I think ocamldoc may also benefit from a bit of care in this respect.) |
Contributor
|
@gasche it's not only Makefile, it's also tools that don't atomically write to files. |
Member
Contributor
|
Thanks a lot @def-lkb . I recently had to bissect the compiler, and those ocamlbuild failures to build (a tad bit ironic...) were a major source of frustration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ocamlbuild/Makefilehad a race condition which might make the build fail occasionally.On test machine with 16 cores,
make -jfailed once every three build.After patch, I got 12 consecutive successful builds.