do not generalize the type of every sub-pattern, only of variables#1745
Merged
trefis merged 2 commits intoocaml:trunkfrom May 4, 2018
Merged
do not generalize the type of every sub-pattern, only of variables#1745trefis merged 2 commits intoocaml:trunkfrom
trefis merged 2 commits intoocaml:trunkfrom
Conversation
lpw25
approved these changes
Apr 30, 2018
Contributor
lpw25
left a comment
There was a problem hiding this comment.
This looks correct and the idea behind the change is fine.
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I said on #1675:
And I mentioned it again here : #1735 (comment) , where @garrigue seemed to agree.