Fix size computation in nativeint_deserialize on MSVC64.#1684
Merged
dra27 merged 1 commit intoocaml:trunkfrom Apr 2, 2018
Merged
Fix size computation in nativeint_deserialize on MSVC64.#1684dra27 merged 1 commit intoocaml:trunkfrom
dra27 merged 1 commit intoocaml:trunkfrom
Conversation
Contributor
|
Do you understand why exactly |
On MSVC64, sizeof(long) is 32. Use sizeof(intnat) for the word size.
630bf25 to
a8752fe
Compare
Contributor
Author
I accidentally committed a bootstrap from #1683, which changes the marshal format. Fixed now. |
nojb
approved these changes
Mar 29, 2018
Contributor
nojb
left a comment
There was a problem hiding this comment.
Seems clearly correct to me.
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On MSVC64, sizeof(long) is 4, despite 8-byte words. Use sizeof(intnat) for the word size.
I don't think this bug can cause any actual failures, though. The marshalling code rounds sizes up to the word size, so this issue doesn't cause problems apart from breaking the build in #1683 (which adds more error checking).