Make the check_all_arches target no-op on 32-bit architectures#1571
Closed
xclerc wants to merge 3 commits intoocaml:trunkfrom
Closed
Make the check_all_arches target no-op on 32-bit architectures#1571xclerc wants to merge 3 commits intoocaml:trunkfrom
xclerc wants to merge 3 commits intoocaml:trunkfrom
Conversation
check_all_arches target no-op on 32-bit architectures
Member
|
Why do you need to disable it? I tried |
damiendoligez
approved these changes
Feb 5, 2018
Member
damiendoligez
left a comment
There was a problem hiding this comment.
If the test is false, you should display a message saying that the test was skipped. It won't change anything for Travis, but it's nicer to the user who launches the test by hand.
Other than that, LGTM
Contributor
Author
Indeed. |
This was referenced Mar 20, 2018
Contributor
Author
|
Due to Travis issues I did not understand, I opened a roughly equivalent PR, #1671, |
rajgodse
added a commit
to rajgodse/ocaml
that referenced
this pull request
Aug 18, 2023
* add partial to typedtree pattern guard type * implements pattern guard translation * added some tests * linear time guardedness check * test file cleanup * convert typedtree pattern into record * remove stray whitespace * removed unnecessary type annotations * bind all record fields in tast_iterator * revise guard patching * adds debug event around pattern guards * abstracts action type * inlines staticfail * enumerate pattern guard fields in mapper * polishes action (now rhs) interface * format: multiline function application Co-authored-by: Nick Roberts <nroberts02@gmail.com> * format: constructor disambiguation Co-authored-by: Nick Roberts <nroberts02@gmail.com> * document handling of partial/total pattern guards * adds cr-soon for rhs efficiency improvement * type annotation to fix compile failure from disambiguation --------- Co-authored-by: Nick Roberts <nroberts02@gmail.com>
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
Co-authored-by: Christine Rose <christinerose@users.noreply.github.com> Co-authored-by: Thibaut Mattio <thibaut.mattio@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the checks are actually run on a 32-bit architecture,
it means (among other things) that the 64-bit code emitters
cannot assume that
nativeintis actually 64-bit.