testsuite: extend the make one target#1530
Conversation
Until now, the make one DIR=... command was able to handle only directories containing legacy tests. This commit extends the target so that it can also handle directories containing ocamltest-driven tests.
|
Thanks a lot, I was thinking of making this PR today but I didn't find the time. |
|
Thanks, I was thinking of making this PR today but I didn't find the time. This is good to merge if the CI approves... but it looks like the CI is not happy. |
|
Summary of the CI output: (all tests reported in the log are skipped or a success.) |
|
Gabriel Scherer (2017/12/14 17:55 +0000):
Thanks a lot, I was thinking of making this PR today but I didn't find
the time.
My pleasure.
It seems the AppVeyor build failed but I think the failure is
irrelevent.
|
|
Gabriel Scherer (2017/12/14 09:59 -0800):
Summary of the [CI output](https://api.travis-ci.org/v3/job/316531101/log.txt):
```
[...]
... testing 'w58.opt.ml' with ocamlopt: => passed
... testing 'w55.opt_backend.ml' with ocamlopt: => passed
... testing 'w59.opt_backend.ml' with ocamlopt: => passed
Running tests from 'tests/win-unicode' ...
... testing 'exec_tests.ml': => skipped
... testing 'mltest.ml': => skipped
... testing 'symlink_tests.ml': => skipped
make[2]: *** [retries] Error 3
make[1]: *** [legacy-without-report] Error 2
make: *** [all] Error 2
```
Well since it was the retries target which failed I thought it was just
an AppVeyor issue. Did I perhaps miss something?
|
|
Some help would be welcome on that one:
|
|
The log that I have shown is from Travis. I can reproduce it on my machine ( awk -v retries=1 -v max_retries=5 -f makefiles/summarize.awk <_log >_retriesreturns the error code |
|
Gabriel Scherer (2017/12/15 09:38 +0000):
The log that I have shown is from Travis. I can reproduce it on my machine. The error comes from the fact that
```shell
awk -v retries=1 -v max_retries=5 -f makefiles/summarize.awk <_log >_retries
```
returns the error code `3`.
Thanks. Same problem here but I don't understand why this is so, I have
to say.
Well the log file seems malformed but at the moment I don't quite
understand why.
|
|
This PR actually breaks an assumption which was important. Currently, in trunk, the exec-one target of testsuite/Makefile only takes The motivation was precisely to be able to run the legacy and new tests Can we perhaps close this PR and continue to live wiht the current situation |
|
Closing as requested. There should be a way to both (1) let us run the test in a give directory reliably, no matter how the tests are written and (2) give people the ability to run only legacy tests or only new test. Both features are things people want. To be investigated later. |
* Update Platform Guiding Principles Commit in stronger terms to keeping Platform tools independent and retain the possibility to use their CLIs directly. * Update data/tutorials/platform/op_00_principles.md Co-authored-by: Christine Rose <christinerose@users.noreply.github.com> --------- Co-authored-by: Anil Madhavapeddy <anil@recoil.org> Co-authored-by: Christine Rose <christinerose@users.noreply.github.com>
Until now, the make one DIR=... command was able to handle only
directories containing legacy tests.
This PR extends the target so that it can also handle directories
containing ocamltest-driven tests.