Skip to content

let rec: allow float array construction with -no-flat-float-array#1516

Merged
gasche merged 2 commits intoocaml:trunkfrom
yallop:flat-float-array-let-rec
Dec 7, 2017
Merged

let rec: allow float array construction with -no-flat-float-array#1516
gasche merged 2 commits intoocaml:trunkfrom
yallop:flat-float-array-let-rec

Conversation

@yallop
Copy link
Copy Markdown
Member

@yallop yallop commented Dec 6, 2017

On #1471, @gasche wrote:

[T]he test file testsuite/tests/typing-misc/pr6939.ml-noflat is broken. When -no-flat-float-array is set, the following definitions should be accepted as valid recursive definitions:

let rec x = [| x |]; 1.;;
let rec x = let u = [|y|] in 10. and y = 1.;;

and currently they are rejected.

This PR adds a check for -no-flat-float-array in the let-rec checking code so that the definitions are accepted and the failing pr6939.ml-noflat passes.

@gasche
Copy link
Copy Markdown
Member

gasche commented Dec 7, 2017

Flawless pull request -- merged. Thanks!

@yallop yallop deleted the flat-float-array-let-rec branch December 7, 2017 08:30
EmileTrotignon pushed a commit to EmileTrotignon/ocaml that referenced this pull request Jan 12, 2024
@yallop yallop mentioned this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants