typecore.ml on Pexp_struct_item: fix #14554#14556
Merged
gasche merged 3 commits intoocaml:trunkfrom Feb 16, 2026
Merged
Conversation
samsa1
reviewed
Feb 16, 2026
Reported-by: Antonio Nuno Monteiro <anmonteiro@gmail.co Co-authored-by: Samuel Vivien <samuel.vivien@inria.fr>
Octachron
approved these changes
Feb 16, 2026
Member
Octachron
left a comment
There was a problem hiding this comment.
I agree with this fix, since Pexp_struct_item introduces a new separate scope for global type variables, and we want to generalize the free type variables after leaving the scope.
Member
Author
|
Thanks! I merged and will cherry-pick into the 5.5 release branch. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR, co-authored with @samsa1, fixes a temporary regression reported by @anmonteiro, introduced in trunk by #13839 (and also a related bug that was already there before).
fixes #14554