Conversation
|
In appveyor_build.sh, I'd suggest to introduce a variable like
flexdll_files := \
flexdll.h flexlink.exe flexdll*_msvc.obj \
default.manifest default_amd64.manifest
And then use that variable in the for loop. It would make the line
shorter and, IMO, improve the readability a bit.
|
|
I find it surprising that you download both
but it's a bit cryptic for the non-expert. Is there a place that describes why you are using these two archives? |
|
@gasche - there's room for expanding the paragraphs in HACKING.adoc on what and how AppVeyor tests, but I don't really want to have to do that here. There was a hiatus with the binary release of FlexDLL 0.36, and the principle change to AppVeyor is to revert necessary changes made in #1200 as FlexDLL 0.37 doesn't require it to be tested that way. I've also reverted a change made 71dfcb5 which should have been reverted in b37db6a slightly longer ago. It doesn't download a " @shindere - I've shortened that line. Sorry, until those check-typo GPRs get merged (I'll deal with the first one shortly), I keep ignoring the output of my githook because it keeps referring to lines which aren't part of the patch! |
|
David Allsopp (2017/10/25 13:15 -0700):
@shindere - I've shortened that line. Sorry, until those check-typo
GPRs get merged (I'll deal with the first one shortly), I keep
ignoring the output of my githook because it keeps referring to lines
which aren't part of the patch!
Okay, np. I guess it'd be nice to somehow make check-typo clever enough
to check just the + lines in patches.
|
Also switch AppVeyor back to only testing the bootstrap on the mingw32 build and some tweaks to the docs.
|
Merged in trunk, cherry-picked in 4.06 ( 3e0a0ac ). |
Turns out the `curl-config` failure is related to these: - actions/runner-images#7958 - actions/runner-images#7945 Explicitly installing curl on macOS shouldn't be necessary, while on `ubuntu-latest`, we have to install `libcurl4-openssl-dev`.
Also switch AppVeyor back to only testing the bootstrap on the mingw32 build and also some tweaks to the docs.
For 4.06 and trunk
It's important to let AppVeyor finish testing this one