Uniformize parsing rules for structure and signature items#14039
Merged
nojb merged 3 commits intoocaml:trunkfrom May 16, 2025
Merged
Uniformize parsing rules for structure and signature items#14039nojb merged 3 commits intoocaml:trunkfrom
nojb merged 3 commits intoocaml:trunkfrom
Conversation
gasche
approved these changes
May 16, 2025
Member
gasche
left a comment
There was a problem hiding this comment.
Nice small consistency improvement. Good to go if the CI agrees.
voodoos
pushed a commit
to voodoos/ocaml
that referenced
this pull request
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cleanup of the parsing rules for structure/signature items to make them more uniform. Addresses a comment by @gasche: #14009 (comment).