Skip to content

tests: native-debugger: sanitize GDB+musl output#14033

Merged
gasche merged 2 commits intoocaml:trunkfrom
MisterDA:tests-native-debugger-gdb-musl
May 14, 2025
Merged

tests: native-debugger: sanitize GDB+musl output#14033
gasche merged 2 commits intoocaml:trunkfrom
MisterDA:tests-native-debugger-gdb-musl

Conversation

@MisterDA
Copy link
Copy Markdown
Contributor

Fixes #14019 with even more sanitation. Precheck on Alpine Linux (GDB+musl) succeeds: https://ci.inria.fr/ocaml/job/precheck/flambda=false,label=ocaml-alpine/1058/.

@gasche
Copy link
Copy Markdown
Member

gasche commented May 14, 2025

I mentioned to @MisterDA that the test is also unstable on my machine (linux, amd64, Fedora) -- if I install lldb, I observe the following output:

--- /home/gasche/Prog/ocaml/github-trunk/testsuite/tests/native-debugger/linux-lldb-amd64.reference	2025-05-13 15:23:15.663486876 +0100
+++ /home/gasche/Prog/ocaml/github-trunk/_ocamltest/testsuite/tests/native-debugger/linux-lldb-amd64/ocamlopt.byte/linux-lldb-amd64.opt.output	2025-05-14 12:20:14.343214810 +0100
@@ -27,7 +27,7 @@
 frame 5: meander`caml_main
 frame 6: meander`main
 frame 7: libc.so.6`__libc_start_call_main
-frame 8: libc.so.6`__libc_start_main_impl
+frame 8: libc.so.6`__libc_start_main@@GLIBC_2.34
 frame 9: meander`_start
 (lldb) continue
 Process XXXX resuming
@@ -44,7 +44,7 @@
 frame 6: meander`caml_main
 frame 7: meander`main
 frame 8: libc.so.6`__libc_start_call_main
-frame 9: libc.so.6`__libc_start_main_impl
+frame 9: libc.so.6`__libc_start_main@@GLIBC_2.34
 frame 10: meander`_start
 (lldb) continue
 Process XXXX resuming
@@ -73,7 +73,7 @@
 frame 10: meander`caml_main
 frame 11: meander`main
 frame 12: libc.so.6`__libc_start_call_main
-frame 13: libc.so.6`__libc_start_main_impl
+frame 13: libc.so.6`__libc_start_main@@GLIBC_2.34
 frame 14: meander`_start
 (lldb) continue
 Process XXXX resuming
@@ -106,6 +106,6 @@
 frame 14: meander`caml_main
 frame 15: meander`main
 frame 16: libc.so.6`__libc_start_call_main
-frame 17: libc.so.6`__libc_start_main_impl
+frame 17: libc.so.6`__libc_start_main@@GLIBC_2.34
 frame 18: meander`_start
 (lldb) quit

@MisterDA MisterDA force-pushed the tests-native-debugger-gdb-musl branch from c220944 to 43f6668 Compare May 14, 2025 11:48
@MisterDA MisterDA requested a review from gasche May 14, 2025 11:49
@MisterDA MisterDA force-pushed the tests-native-debugger-gdb-musl branch from 43f6668 to bf40de4 Compare May 14, 2025 12:31
@MisterDA
Copy link
Copy Markdown
Contributor Author

Final version, which works on Gabriel's machine.

@gasche gasche merged commit 8835a8b into ocaml:trunk May 14, 2025
23 of 24 checks passed
@MisterDA MisterDA deleted the tests-native-debugger-gdb-musl branch May 15, 2025 09:44
dra27 pushed a commit that referenced this pull request Jan 10, 2026
tests: native-debugger: sanitize GDB+musl output
(cherry picked from commit 8835a8b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test tests/native-debugger/linux-gdb-amd64 is fragile

2 participants