Skip to content

Update FlexDLL to 0.44 and reenable lib-dynlink-domains test on Windows#14032

Merged
dra27 merged 2 commits intoocaml:trunkfrom
jmid:flexdll-0.44
May 14, 2025
Merged

Update FlexDLL to 0.44 and reenable lib-dynlink-domains test on Windows#14032
dra27 merged 2 commits intoocaml:trunkfrom
jmid:flexdll-0.44

Conversation

@jmid
Copy link
Copy Markdown
Member

@jmid jmid commented May 14, 2025

This PR

Fixes #13046

CC: @dra27

@MisterDA
Copy link
Copy Markdown
Contributor

MisterDA commented May 14, 2025

All in favor raise hands! ✋
In passing I suggest we add a branch = master entry to the .gitmodules file under flexdll. It helps when one wants to test a custom branch in CI, or when using git submodule update --remote. See also MisterDA@c705b55.
Note that FlexDLL 0.44 has already been released to the opam-repository, and all (updated) Windows switches have started using it.

Copy link
Copy Markdown
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dra27
Copy link
Copy Markdown
Member

dra27 commented May 14, 2025

In passing I suggest we add a branch = master entry to the .gitmodules file under flexdll.

Sure! The main thing is that I think the commits should be the commits of release tags (as this PR does), but it sounds as though doing this wouldn't interfere with that.

@dra27 dra27 merged commit 6cca9ff into ocaml:trunk May 14, 2025
32 of 33 checks passed
dra27 added a commit that referenced this pull request May 14, 2025
Update FlexDLL to 0.44 and reenable lib-dynlink-domains test on Windows

(cherry picked from commit 6cca9ff)
@jmid jmid deleted the flexdll-0.44 branch May 14, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parallel Dynlink usage under Cygwin+MinGW is unsafe

3 participants