Cleanups following introduction of Pexp_struct_item/Texp_struct_item#14028
Merged
nojb merged 3 commits intoocaml:trunkfrom May 13, 2025
Merged
Cleanups following introduction of Pexp_struct_item/Texp_struct_item#14028nojb merged 3 commits intoocaml:trunkfrom
Pexp_struct_item/Texp_struct_item#14028nojb merged 3 commits intoocaml:trunkfrom
Conversation
916c24b to
30d10f3
Compare
Member
|
The |
gasche
approved these changes
May 13, 2025
Member
gasche
left a comment
There was a problem hiding this comment.
This looks good to me, we should merge it if the CI passes.
Contributor
Author
|
Thanks for the comments/review! |
MisterDA
pushed a commit
to MisterDA/ocaml
that referenced
this pull request
May 16, 2025
…em` (ocaml#14028) * Remove stale comments * Remove dead constructor: Scoping_let_module * Remove eqparsetree.ml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cleanups related to #13839.
Remove some comments which referenced
Pexp_letmoduleand that no longer make sense (I did not see how to adapt them and still make sense).Remove an "error" constructor
Scoping_let_module; this error was not exercised in the testsuite and so I had not noticed that it had become dead code (supposedly the same error now reports a more general "out of scope" error message).Remove
tools/eqparsetree.ml: this code is not compiled and seems to be out of date.Lastly, it was indicated to me offline that the new construct
Pexp_struct_itemwould be better namedPexp_let_struct_item(and same forTexp_struct_item). Since we still have the possibility of doing this kind of renaming, I am putting this up for consideration here. (I could do the renaming in this PR if there is a decision to do so.)Fixes #13839 (comment)