Merged
Conversation
gasche
approved these changes
Apr 25, 2025
Member
gasche
left a comment
There was a problem hiding this comment.
Approved in principle, see comment on comment.
| constitute a data race as this is a volatile load. However, TSan will | ||
| wrongly see a race here (see section 3.2 of comment in tsan.c). We | ||
| therefore make sure it is never TSan-instrumented. */ | ||
| value v = volatile_load_uninstrumented(&Field(block, i)); |
Member
There was a problem hiding this comment.
I'm not fond of the redundancy introduced by duplicating the comment. Could you move the comment to the helper function definition, instead of repeating it at the callsite? (It might also be an occasion to clarify it a bit: if I understand correctly, the point is that these loads may race with mutator access, and/but that we have decided that these races are benign. The "does not constitute a data race" part of the comment is a bit confusing to me, I think it suggests that this is not UB?)
957fcae to
d4be0b1
Compare
d4be0b1 to
ce595a5
Compare
Member
|
Merged in trunk and backported in 5.4 ( da99532 ). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion in #13427.