Make ocamlmklib fail on unknown parameter#13638
Conversation
|
Thanks a lot. Approving but not merging, so that @dra27 can What about making the commit message a bit more explicit, at least Independently of this PR, I noticed that ocamlmklib does not |
09b00c6 to
87d1f6b
Compare
I don't expect so (Debian adds one) - although I'm not sure this is something we should do prior to overhauling the way they're generated (it's already necessary to keep two places in sync, given the documentation in the "Interfacing with C" chapter and also the |
|
Gentle ping for @damiendoligez |
This reverts commit 31cbd26.
87d1f6b to
99bf62e
Compare
|
I didn't see a good reason to wait indefinitely on this one, so I went ahead and merged. |
In the spirit of #12613. The original
ocamlmklibshell script used to ignore command line options it didn't recognise (I'm going to guess for build system simplicity). The present OCaml rewrite of it was introduced in OCaml 3.04 and temporarily did return an error status, but this got "corrected" in 31cbd26.I can see why this might have been acceptable 20+ years ago, but I don't think it's good or consistent (and I just got bitten by it while trying to write some sanity-checking tests...). The rest of the distribution returns a non-zero status when passed on invalid argument - so should ocamlmklib!
(cc @garrigue, but only because the original commit is yours!)