Make ocamlc/ocamlopt fail when not given input files#12613
Merged
Octachron merged 2 commits intoocaml:trunkfrom Oct 5, 2023
Merged
Make ocamlc/ocamlopt fail when not given input files#12613Octachron merged 2 commits intoocaml:trunkfrom
Octachron merged 2 commits intoocaml:trunkfrom
Conversation
Contributor
|
Thanks! I indeed reviewed but would like this to also be reviewed by
somebody else.
Especially, changing the behaviour of the compiler when it is passed no
arguemnt atall was not part of the initial plan so it'd be good to make
sure this change is wanted, too.
|
shindere
approved these changes
Oct 4, 2023
An invocation such as `ocamlc` (without any command-line parameters), or `ocamlc -o a.out` will now fail with an error message and an error code.
3b56078 to
e07e433
Compare
Contributor
Author
|
Rebased to fix conflicts in Changes. |
Contributor
|
This has been discussed in triaging meeting and it has been agreed that This PR should be good to go once it has been rebased to solve the conflict |
Contributor
|
As discussed during today's triage meeting: the "no input files" error behavior looks good, that's what GCC, Clang and CompCert do. |
Contributor
|
FYI, ocamlfind used to rely on the former behaviour: ocaml/ocamlfind#78 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An invocation such as
ocamlc(without any command-line parameters), orocamlc -o a.outwill now fail with an error message and an error code.cc @shindere who reviewed the PR offline
fixes #12497