Restore the {ocamlc,ocamlopt}_{cflags,cppflags} config vars#13244
Merged
shindere merged 1 commit intoocaml:trunkfrom Jun 21, 2024
Merged
Restore the {ocamlc,ocamlopt}_{cflags,cppflags} config vars#13244shindere merged 1 commit intoocaml:trunkfrom
shindere merged 1 commit intoocaml:trunkfrom
Conversation
e4de813 to
dd209cd
Compare
MisterDA
approved these changes
Jun 18, 2024
Changes
Outdated
| Miod Vallat and Samuel Hym) | ||
|
|
||
| * #13201: Fix and speedup builds with TSan. | ||
| - #13201j #13244: Fix and speedup builds with TSan. |
Contributor
There was a problem hiding this comment.
Suggested change
| - #13201j #13244: Fix and speedup builds with TSan. | |
| - #13201 #13244: Fix and speedup builds with TSan. |
These variables have been renamed by ocaml#13201 but should actually have been preserved so that the use of `ocamlc -config` remains backward-compatible.
dd209cd to
1f97e10
Compare
Contributor
Author
ghost
approved these changes
Jun 19, 2024
OlivierNicole
approved these changes
Jun 19, 2024
Contributor
OlivierNicole
left a comment
There was a problem hiding this comment.
Approving on behalf of @anmonteiro, @MisterDA and @dustanddreams. I note that we may one day want to design a way to deprecate the old variables, but that is a longer discussion and for a later PR.
Contributor
Author
|
Thanks a lot for the approval.
Such a deprecation mechanism would indeed be helpful.
Perhaps emiting a warning on stderr could work. To be tested on opam, I
guess.
|
Contributor
I don't think that's possible in the current interface, since users do |
Contributor
Author
|
OK thanks! So I'm guessing that the only option we are left with will be
to `opam grep` for the old names and fix what it reports.
|
punchagan
added a commit
to punchagan/sandmark
that referenced
this pull request
Jun 21, 2024
This reverts commits 19c98b1 and 7e5deb0. Upstream restored the variables that were removed in ocaml/ocaml#13201 in ocaml/ocaml#13244 for backward-compatibility.
punchagan
added a commit
to ocaml-bench/sandmark
that referenced
this pull request
Jun 21, 2024
This reverts commits 19c98b1 and 7e5deb0. Upstream restored the variables that were removed in ocaml/ocaml#13201 in ocaml/ocaml#13244 for backward-compatibility.
Member
|
Concerning the deprecation policy and backward-compatibility guarantees, I think that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These variables have been renamed by #13201 but should actually have
been preserved so that the use of
ocamlc -configremainsbackward-compatible.