Export Cmt2annot.{iterator,binary_part}#13228
Conversation
These two functions are used by ocamlbrowser.
|
This looks good to me, modulo the nitpick that the order of the |
|
Thanks for the fast PR. I'm still wondering what to do for ocamlbrowser on ocaml 5.2. |
Yes, this is OK. The people who wrote and then made substantial changes to this file will become contributors of ocamlbrowser, which is fine. Note: I think that it's not necessarily a bad thing that you adopt this part of the logic and have the opportunity to adopt/refine/simplify it based on the needs of ocamlbrowser. Maybe you will find in the end that this is better than hooking into this specific compiler-libs module, time will tell. |
|
Would it help if we'd backport this fix to 5.2, assumingthere will be a
5.2.1 release at some point?
|
I don't think it is necessary. For this release, compatible with 5.2, I will include cmt2annot.ml in the labltk distribution. |
Add the missing reviewer entry for PR #13228
Following up #11288 (comment) - there may be some further discussion wanted as to how much support should remain here for annot files, but as a starting point and to track the issue, here's a PR re-exporting those functions again.
cc @garrigue