A giant leap towards enforcing tools/check-typo on the entire repository#1288
A giant leap towards enforcing tools/check-typo on the entire repository#1288dra27 merged 2 commits intoocaml:trunkfrom
Conversation
|
All the changes in this GPR relate to reducing line-lengths and fixing whitespace. |
1c28da8 to
093ae0b
Compare
bd5dba4 to
9777a9d
Compare
|
@dra27 I think we should drop this PR and try again later (maybe piecewise?) |
|
I don't think it needs breaking up - just rebasing (and updating). |
|
But won't it be too hard to rebase? |
|
No - I've already done it! Just testing it... it's revealed a couple of little changes to ocamltest, so once the whole testsuite is passing again, I'll split the new bits into separate pull requests and push the new version of this one just with whitespace/line-length altering changes. |
|
Great! Many thanks for the hard work, @dra27!
|
|
OK, this single commit contains fixes which are solely the correction of whitespace (with occasional knock-on consequences for the testsuite reference files) and overly long lines. Overly long lines are fixed using (hopefully) non-controversial string-splitting, etc. This diff is much easier to look at using a whitespace-eliminating diff tool such as |
|
A clearer view of this diff may be found at http://people.ds.cam.ac.uk/dra27/gpr1288-patdiff.html |
8228d44 to
fc36b23
Compare
fc36b23 to
a9c85ba
Compare
|
Rebased, partly to kick AppVeyor, and partly because this branch should now represent a fully check-typo passing |
|
OK - assuming the revised version with GPR#1825 whitespace fixes passes, can this be merged? The patdiff-generated diff above is still correct (rebasing didn't have any conflicts). |
damiendoligez
left a comment
There was a problem hiding this comment.
I have reviewed the patdiff and everything looks correct.
|
Thanks, @damiendoligez! Here goes, and apologies to everyone whose patches need updating... |
|
David Allsopp (2018/06/14 07:15 -0700):
Merged #1288.
Congrats! and many, many thanks for your hard work on this!!!
|
Follows on from #1287, which needs merging first. The actual changes are just the last commit - 1c28da8