Fix assertion in caml_ephe_clean#12860
Merged
Octachron merged 1 commit intoocaml:trunkfrom Feb 21, 2024
Merged
Conversation
gasche
approved these changes
Dec 22, 2023
Member
gasche
left a comment
There was a problem hiding this comment.
This is correct.
(There is no other use of is_marked anywhere, so I wondered if the definition instead of the callsite should be updated, possibly with a rename to is_marked_or_unmarkable. But I have no strong opinion and @mshinwell knows this code better.)
Contributor
Author
|
@kayceesrk do you have an opinion on this point? |
kayceesrk
approved these changes
Dec 27, 2023
Contributor
kayceesrk
left a comment
There was a problem hiding this comment.
This change looks fine to me.
Member
|
Please add a Changes entry for 5.2. |
Octachron
added a commit
that referenced
this pull request
Feb 21, 2024
Fix assertion in caml_ephe_clean (cherry picked from commit 5cfc104)
Member
|
Changes entry added and PR cherry-picked to 5.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This assertion wasn't taking into account the possibility of an ephemeron pointing at static data.
(Will add Changes entry later.)