Remove the Closure module from Obj#12625
Merged
xavierleroy merged 3 commits intoocaml:trunkfrom Oct 4, 2023
Merged
Conversation
xavierleroy
approved these changes
Oct 3, 2023
Contributor
xavierleroy
left a comment
There was a problem hiding this comment.
I'd be happy to see this hack go away. Is there a way to confirm it's not used anywhere? Like an OPAM-wide grep?
Member
|
Sherlocode to the rescue! Obj.Closure instances only show up once, as part of a forked compiler package. |
Contributor
|
Fine! Let's merge, then. |
sadiqj
pushed a commit
to sadiqj/ocaml
that referenced
this pull request
Oct 8, 2023
This module was introduced in ocaml#9691, for use in CamlinternalMod, but rendered obsolete by ocaml#10205.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was introduced in #9691, for use in
CamlinternalMod, but rendered obsolete by #10205.It could have been used outside the compiler, but given that it doesn't support all closures (it fails on infix ones), I don't think it's useful on its own.