Merged
Conversation
gasche
approved these changes
Sep 11, 2023
Member
gasche
left a comment
There was a problem hiding this comment.
The fix is obviously correct, but have you gone over the initial PR again to see if we made the same mistake in other places?
Member
Author
|
I have: there is only one caller of |
This was referenced Sep 12, 2023
Octachron
pushed a commit
to Octachron/ocaml
that referenced
this pull request
Feb 20, 2024
Fix cmi lookup after ocaml#12389 (cherry picked from commit eab1105)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR #12389 restricted the lookup for cmi file when compiling
pa/th/name.mid.mlto{P,p}a/th/name.mid.mlwhich is a far too strict behavior.This PR restores the intending behavior by looking for any cmi file in the load paths whose basename normalize to "name.cmi".