manual: ocamlyacc parsers are not thread-safe#11562
Merged
Octachron merged 1 commit intoocaml:trunkfrom Sep 26, 2022
Merged
Conversation
gasche
approved these changes
Sep 23, 2022
Member
gasche
left a comment
There was a problem hiding this comment.
Approved. Note that this note was already true of 4.x, and would remain true even in presence of crash-safety mitigations discussed in the other PR.
Octachron
added a commit
that referenced
this pull request
Sep 26, 2022
manual: ocamlyacc parsers are not thread-safe (cherry picked from commit 7410c2c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a lightweight alternative to #11225 that proposes to document that ocamlyacc is not concurrency-safe in any way, and points to menhir as a better parser generator.