caml_make_float_vect in no-flat-float array: use static allocation#11552
Merged
xavierleroy merged 3 commits intoocaml:trunkfrom Sep 23, 2022
Merged
caml_make_float_vect in no-flat-float array: use static allocation#11552xavierleroy merged 3 commits intoocaml:trunkfrom
xavierleroy merged 3 commits intoocaml:trunkfrom
Conversation
Allocate the initializing float statically and outside the heap, rather than dynamically at first use. Not only it's more efficient, but it also avoids a race condition. Fixes: ocaml#11504
16fee9c to
fbd6a8d
Compare
Contributor
Author
|
Cherry-picked to 5.0: 4164b49 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allocate the initializing float block statically and outside the heap, rather than dynamically at first use. Not only it's more efficient, but it also avoids the race condition reported in #11504.
Fixes: #11504