recommended_domain_count: unit -> int#11545
Merged
xavierleroy merged 1 commit intoocaml:trunkfrom Sep 21, 2022
Merged
Conversation
Presenting this as a function rather than a constant in the stdlib leaves us with more implementation options open in the future.
e1b669e to
bcc0f32
Compare
haesbaert
approved these changes
Sep 14, 2022
Contributor
|
@Octachron: is it still time to have this change in 5.0 ? Otherwise we'll have an incompatibility between 5.0 and 5.1. |
Member
|
We really want this change in 5.0: it is better to break the API before the first 5.0 beta and hope that no one has yet a critical system in production that depends on the 5.0~alpha1. That might be less true if we wait for 5.1 . |
xavierleroy
approved these changes
Sep 21, 2022
Contributor
xavierleroy
left a comment
There was a problem hiding this comment.
OK, let's have this in 5.0.
xavierleroy
pushed a commit
that referenced
this pull request
Sep 21, 2022
Presenting this as a function rather than a constant in the stdlib leaves us with more implementation options open in the future. (cherry picked from commit a73df93)
Contributor
|
Cherry-picked to 5.0: 4a60998 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #11309 (comment). (cc @xavierleroy, @haesbaert )