fix #11482: random crash in large closure allocation#11542
Merged
damiendoligez merged 1 commit intoocaml:trunkfrom Sep 20, 2022
Merged
fix #11482: random crash in large closure allocation#11542damiendoligez merged 1 commit intoocaml:trunkfrom
damiendoligez merged 1 commit intoocaml:trunkfrom
Conversation
Member
Author
|
Checked on 5.0.0~alpha0, it does fix the segfault. Now ready for review. |
Member
Author
|
Note: will have to move the Changes entry and cherry-pick to 5.0. |
xavierleroy
approved these changes
Sep 17, 2022
Contributor
There was a problem hiding this comment.
This looks like a good fix for #11482. Two minor remarks:
- I'm not super happy about the function name
caml_alloc_shr_with_safepoint. Ischeck_urgent_gcequivalent to the safe points that ocamlopt implements?caml_alloc_shr_check_urgentmight be more descriptive.caml_alloc_shr_checkwould be shorter :-) - I wondered about performance. We can probably assume that ocamlopt-generated code rarely allocates directly in the major heap, in which case performance should be OK.
6d40d15 to
3dae3ac
Compare
3dae3ac to
4a6c505
Compare
Member
Author
|
I've renamed the function to |
xavierleroy
approved these changes
Sep 19, 2022
Contributor
xavierleroy
left a comment
There was a problem hiding this comment.
Looks good to me, thanks. Could you please move the Changes entry to 5.0, merge in trunk, and cherry-pick -x in 5.0 ? Thanks.
damiendoligez
added a commit
that referenced
this pull request
Sep 20, 2022
Member
Author
|
Cherry-picked to 5.0 (as 43754a5). Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this is still a draft, I still want to check that it does make the bug disappear.
Fixes #11482