Turn some partial application warnings into hints#11338
Merged
lpw25 merged 2 commits intoocaml:trunkfrom Jun 24, 2022
Merged
Conversation
Contributor
Author
|
As shown in the tests, we go from: to: |
Contributor
|
Agreed, this is nicer. |
Contributor
Author
|
Changes entry added. I'll merge when the CI is green. |
lukemaurer
pushed a commit
to lukemaurer/ocaml
that referenced
this pull request
Jul 19, 2022
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
Sep 21, 2022
0b0aefb Turn some partial application warnings into hints (ocaml#11338) (ocaml#30) 2caa9ee Add [@tail] and [@nontail] annotations on applications to control tailcalls (ocaml#31) 9fb218a Update `promote` target to use the `one` machinery (ocaml#28) b5ea912 Make empty types immediate bc08236 Add failing test of an empty type being immediate f2d439f Propagate escaping_context to Env locks to hint about errors (ocaml#25) 35569e1 Allow warning 68 to be controlled by attributes (ocaml#16) 28a6243 Allow type_argument to weaken return modes of expected function types (ocaml#24) cdc728f Fix 'make alldepend' in otherlibs/dynlink 7807d18 make alldepend 2d6af2f Merge flambda-backend changes git-subtree-dir: ocaml git-subtree-split: 0b0aefb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9560 added some additional partial applications warnings when there is a type error. However, these would more naturally appear as a hint within the error message. This PR replaces those warnings with a hint.