Skip to content

Manual: fix link to Ast mapper module#1129

Merged
gasche merged 1 commit intoocaml:4.05from
Octachron:manual_missing_link
Mar 31, 2017
Merged

Manual: fix link to Ast mapper module#1129
gasche merged 1 commit intoocaml:4.05from
Octachron:manual_missing_link

Conversation

@Octachron
Copy link
Copy Markdown
Member

This short PR fixes the link to the ast_mapper module in ocaml{c,opt} documentation. The reference ast-underscoremapper was unresolved in the html version of the manual due to a subtle difference of structure between the latex and html version of the manual:
in the latex version, the documentation of modules is directly integrated in the manual structure, whereas this documentation is merely linked to in the html version.

This PR proposes therefore to use an inner reference in the latex version, and a link in the html version of the manual.

@gasche
Copy link
Copy Markdown
Member

gasche commented Mar 31, 2017

Why was the LaTeX reference changed from "chapter" to "section", I assume this is an intentional and correct change?

@Octachron
Copy link
Copy Markdown
Member Author

Indeed, the AST_mapper documentation is (in the latex manual at least) a section of the Compiler front-end chapter (referred as chapter \ref{c:parsinglib} in the html output), not a chapter by itself.

@gasche gasche merged commit 9221222 into ocaml:4.05 Mar 31, 2017
@gasche
Copy link
Copy Markdown
Member

gasche commented Mar 31, 2017

Thanks. Merged in 4.05, cherry-picked in trunk.

camlspotter pushed a commit to camlspotter/ocaml that referenced this pull request Oct 17, 2017
stedolan pushed a commit to stedolan/ocaml that referenced this pull request Mar 21, 2023
EmileTrotignon pushed a commit to EmileTrotignon/ocaml that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants