stdlib concurrency safety documentation, part two: global states#11227
Merged
Octachron merged 1 commit intoocaml:trunkfrom Nov 24, 2022
Merged
stdlib concurrency safety documentation, part two: global states#11227Octachron merged 1 commit intoocaml:trunkfrom
Octachron merged 1 commit intoocaml:trunkfrom
Conversation
This was referenced Apr 29, 2022
kayceesrk
approved these changes
Nov 2, 2022
Contributor
kayceesrk
left a comment
There was a problem hiding this comment.
The change is reasonable and looks good to me.
Member
Author
|
I would propose to merge the alert name with the one (once we agree) used in the first PR to avoid duplicating the number of alerts. |
81240c5 to
0c291b6
Compare
Octachron
added a commit
that referenced
this pull request
Nov 24, 2022
…light stdlib concurrency safety documentation, part two: global states (cherry picked from commit 4f23169)
Member
Author
|
Cherry-picked on 5.0 as 1deb3e5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #11193 and #11225, this PR adds a new alert in the standard library for global mutable states that are expected to be fully handled by users. More precisely, this PR adds a alert for
Argmodule: the arguments of the program should be parsed only once.GC, accessible throughGc.getandGc.setSys.enable_runtime_warningsandSys.runtime_warnings_enableSys.interactiveThere is two other global states present in
HashtblandFilename: one state tracks if hashtables are randomized by default, and another state stores the directory name for temporary files. However, those two state seem to be a good enough fit for inheritable domain local state, I am thus proposing for now to change their implementation in #11228.