Revert "Deprecate Bigarray.*.map_file and add Unix.map_file (#997)"#1102
Merged
xavierleroy merged 1 commit intoocaml:4.05from Mar 13, 2017
Merged
Revert "Deprecate Bigarray.*.map_file and add Unix.map_file (#997)"#1102xavierleroy merged 1 commit intoocaml:4.05from
xavierleroy merged 1 commit intoocaml:4.05from
Conversation
1c11ace to
bf5a61b
Compare
This reverts commit 5ed7200. GPR#997 introduced a hard dependency of Bigarray on Unix, while there previously only was a type-level dependency. This break some programs, such as Camomile, that linked bigarray.cma but not unix.cma. A solution is being worked out in GPR ocaml#1077 to remove the dependency, but I would like to go forward with opam package testing on the 4.05 branch, and getting the details right for GPR#1077 requires some care, so I wouldn't feel comfortable rushing to merge it. I had to handle the following conflicts: otherlibs/unix/unix.mli ("@SInCE 4.05.0" was added in faab91a) testsuite/tests/lib-bigarray-file/mapfile.ml (changed by 5839c98; I kept and adapted the new version) testsuite/tests/lib-bigarray-file/mapfile.reference
Contributor
|
map_file is missing from UnixLabels |
camlspotter
pushed a commit
to camlspotter/ocaml
that referenced
this pull request
Oct 17, 2017
Revert "Deprecate Bigarray.*.map_file and add Unix.map_file (ocaml#997)" This revert is intended to unblock the OPAM package testing of 4.05.
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
Mar 21, 2023
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
* mention Docker Hub images --------- Co-authored-by: Cuihtlauac ALVARADO <cuihtlauac@tarides.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 5ed7200.
GPR#997 introduced a hard dependency of Bigarray on Unix, while there
previously only was a type-level dependency. This break some programs,
such as Camomile, that linked bigarray.cma but not unix.cma.
A solution is being worked out in GPR #1077 to remove the dependency,
but I would like to go forward with opam package testing on the 4.05
branch, and getting the details right for GPR#1077 requires some care,
so I wouldn't feel comfortable rushing to merge it.
I had to handle the following conflicts:
("@SInCE 4.05.0" was added in faab91a)
(changed by 5839c98;
I kept and adapted the new version)
(promoted)