Merged
Conversation
Member
AltGr
commented
Jan 27, 2021
- re-add the "native toplevel" message when running the native toplevel.
- simplify internal functor followinf @Drup's review
gasche
approved these changes
Jan 27, 2021
Member
gasche
left a comment
There was a problem hiding this comment.
Approved in principle, see minor comment. Thanks!
toplevel/native/topeval.ml
Outdated
| external ndl_run_toplevel: string -> string -> res | ||
| = "caml_natdynlink_run_toplevel" | ||
|
|
||
| let implementation_label = " - native toplevel" |
Member
There was a problem hiding this comment.
I'm sorry to be that nitpicking guy again, but I would use Some "native toplevel" and decide on the dash at render-time.
Member
|
(It looks like you need to promote some testsuite files who depend on the locations within the changed module.) |
ghost
reviewed
Jan 27, 2021
| val getvalue : string -> Obj.t | ||
| val setvalue : string -> Obj.t -> unit | ||
|
|
||
| val implementation_label: string |
There was a problem hiding this comment.
I feel like this deserve a comment:
Suggested change
| val implementation_label: string | |
| (** String displayed after [OCaml version XXX] when starting the toplevel. *) | |
| val implementation_label: string |
There was a problem hiding this comment.
(or what @gasche said, just saw his comment)
It was dropped in ocaml#10124. It seemed cleaner and safer to add the string to the specific module used rather than trivially rely on `Sys.backend_type`. The string is left empty for the bytecode toplevel, to avoid a visible change from the current version.
smuenzel
pushed a commit
to smuenzel/ocaml
that referenced
this pull request
Mar 30, 2021
- Toplevel factorisation: simplify MakePrinter functor - Re-add a discrimination string to the native toplevel header It seemed cleaner and safer to add the string to the specific module used rather than trivially rely on `Sys.backend_type`. The string is left empty for the bytecode toplevel, to avoid a visible change from the current version.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.