Merged
Conversation
voodoos
approved these changes
Dec 6, 2022
Collaborator
voodoos
left a comment
There was a problem hiding this comment.
Looks good to me, thanks !
voodoos
added a commit
to voodoos/merlin
that referenced
this pull request
Dec 13, 2022
from antalsz/unused-c-variables
voodoos
added a commit
that referenced
this pull request
Dec 13, 2022
from antalsz/unused-c-variables
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Dec 13, 2022
CHANGES:
Thu Dec 13 11:49:42 CEST 2022
+ merlin binary
- Restore compatibility with the compiler's command line by accepting
the `-safe-string` flag as a no-op instead of rejecting it. (ocaml/merlin#1544,
fixes ocaml/merlin#1518)
- Mark some C variables as unused to remove warnings (ocaml/merlin#1541, @antalsz)
voodoos
added a commit
to voodoos/merlin
that referenced
this pull request
May 2, 2024
from antalsz/unused-c-variables
voodoos
added a commit
to voodoos/merlin
that referenced
this pull request
May 2, 2024
from antalsz/unused-c-variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a couple of non-
#ifdef _WIN32C functions that don't use their arguments; this PR marks those arguments as unused., silencing some warnings.