Fix locate on module without implementation#1522
Merged
voodoos merged 6 commits intoocaml:masterfrom Nov 17, 2022
Merged
Conversation
voodoos
added a commit
to voodoos/merlin
that referenced
this pull request
Nov 17, 2022
47f6033 to
7ca12af
Compare
Add a test for modules without a signature more without sig tests More implemn tests
voodoos
added a commit
to voodoos/merlin
that referenced
this pull request
Nov 17, 2022
7ca12af to
680e6c0
Compare
680e6c0 to
28d5791
Compare
Member
|
Ah, I hadn't seen this. You pinged someone else. |
Collaborator
Author
|
Oups :-D |
Collaborator
Author
|
Feel free to try the master branch ! |
Member
|
I did! It works perfectly. Thanks! |
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Nov 24, 2022
CHANGES:
Thu Nov 24 13:31:42 CEST 2022
+ merlin binary
- Replace custom "holes" AST nodes by extensions. This restores binary
compatibility and fixes issues with PPXs when using typed-holes.
(ocaml/merlin#1503)
- Do not change temporarily Merlin's cwd when starting a PPX (ocaml/merlin#1521,
fixes ocaml/merlin#1420)
- Fix a parsing issue when declaring the `(??)` custom prefix operator.
(ocaml/merlin#1507, fixes ocaml/merlin#1506)
- Fix variant constructors' comments grouping (ocaml/merlin#1516, @mheiber, fixes ocaml/merlin#1513)
- Filter-out duplicates from the `enclosing` command result (ocaml/merlin#1512)
- Add a new `verbosity=smart` mode for type enclosing that only expand
modules' types (ocaml/merlin#1374, @ulugbekna)
- Improve locate for labels' declarations in the current buffer.
(ocaml/merlin#1505, fixes ocaml/merlin#1524)
- Fix locate on module without implementation (ocaml/merlin#1522, fixes ocaml/merlin#1519)
- Allow program name customization when merlin is used as a library. (ocaml/merlin#1532)
+ editor modes
- vim: load the plugin when necessary if it wasn't loaded before (ocaml/merlin#1511)
- emacs: update CI for newer releases and fix some warnings (ocaml/merlin#1454,
@mattiase)
+ test suite
- Add tests for constructors' documentation (ocaml/merlin#1511)
- Add test cases for label comment documentation (ocaml/merlin#1526, @mheiber)
- Add a test for the `enclosing` command (ocaml/merlin#1512)
- Add tests for interactions between locate and record labels (ocaml/merlin#1505)
- Add test showing an issue with locate and implicit transitive deps
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Nov 24, 2022
CHANGES:
+ merlin binary
- Replace custom "holes" AST nodes by extensions. This restores binary
compatibility and fixes issues with PPXs when using typed-holes.
(ocaml/merlin#1503)
- Do not change temporarily Merlin's cwd when starting a PPX (ocaml/merlin#1521,
fixes ocaml/merlin#1420)
- Fix a parsing issue when declaring the `(??)` custom prefix operator.
(ocaml/merlin#1507, fixes ocaml/merlin#1506)
- Fix variant constructors' comments grouping (ocaml/merlin#1516, @mheiber, fixes ocaml/merlin#1513)
- Filter-out duplicates from the `enclosing` command result (ocaml/merlin#1512)
- Add a new `verbosity=smart` mode for type enclosing that only expand
modules' types (ocaml/merlin#1374, @ulugbekna)
- Improve locate for labels' declarations in the current buffer.
(ocaml/merlin#1505, fixes ocaml/merlin#1524)
- Fix locate on module without implementation (ocaml/merlin#1522, fixes ocaml/merlin#1519)
- Allow program name customization when merlin is used as a library. (ocaml/merlin#1532)
+ editor modes
- vim: load the plugin when necessary if it wasn't loaded before (ocaml/merlin#1511)
- emacs: update CI for newer releases and fix some warnings (ocaml/merlin#1454,
@mattiase)
+ test suite
- Add tests for constructors' documentation (ocaml/merlin#1511)
- Add test cases for label comment documentation (ocaml/merlin#1526, @mheiber)
- Add a test for the `enclosing` command (ocaml/merlin#1512)
- Add tests for interactions between locate and record labels (ocaml/merlin#1505)
- Add test showing an issue with locate and implicit transitive deps
[new release] merlin (4.7-413)
CHANGES:
+ merlin binary
- Replace custom "holes" AST nodes by extensions. This restores binary
compatibility and fixes issues with PPXs when using typed-holes.
(ocaml/merlin#1503)
- Fix a parsing issue when declaring the `(??)` custom prefix operator.
(ocaml/merlin#1507, fixes ocaml/merlin#1506)
- Fix variant constructors' comments grouping (ocaml/merlin#1516, @mheiber, fixes ocaml/merlin#1513)
- Filter-out duplicates from the `enclosing` command result (ocaml/merlin#1512)
+ editor modes
- vim: load the plugin when necessary if it wasn't loaded before (ocaml/merlin#1511)
+ test suite
- Add tests for constructors' documentation (ocaml/merlin#1511)
- Add test cases for label comments documentation (ocaml/merlin#1526, @mheiber)
- Add a test for the `enclosing` command (ocaml/merlin#1512)
[new release] merlin (4.7-412)
CHANGES:
+ merlin binary
- Replace custom "holes" AST nodes by extensions. This restores binary
compatibility and fixes issues with PPXs when using typed-holes.
(ocaml/merlin#1503)
- Fix a parsing issue when declaring the `(??)` custom prefix operator.
(ocaml/merlin#1507, fixes ocaml/merlin#1506)
- Fix variant constructors' comments grouping (ocaml/merlin#1516, @mheiber, fixes ocaml/merlin#1513)
- Filter-out duplicates from the `enclosing` command result (ocaml/merlin#1512)
+ editor modes
- vim: load the plugin when necessary if it wasn't loaded before (ocaml/merlin#1511)
+ test suite
- Add tests for constructors' documentation (ocaml/merlin#1511)
- Add test cases for label comment documentation (ocaml/merlin#1526, @mheiber)
- Add a test for the `enclosing` command (ocaml/merlin#1512)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Nov 24, 2022
CHANGES:
Thu Nov 24 17:49:42 CEST 2022
+ merlin binary
- Replace custom "holes" AST nodes by extensions. This restores binary
compatibility and fixes issues with PPXs when using typed-holes.
(ocaml/merlin#1503)
- Do not change temporarily Merlin's cwd when starting a PPX (ocaml/merlin#1521,
fixes ocaml/merlin#1420)
- Fix a parsing issue when declaring the `(??)` custom prefix operator.
(ocaml/merlin#1507, fixes ocaml/merlin#1506)
- Fix variant constructors' comments grouping (ocaml/merlin#1516, @mheiber, fixes ocaml/merlin#1513)
- Filter-out duplicates from the `enclosing` command result (ocaml/merlin#1512)
- Add a new `verbosity=smart` mode for type enclosing that only expand
modules' types (ocaml/merlin#1374, @ulugbekna)
- Improve locate for labels' declarations in the current buffer.
(ocaml/merlin#1505, fixes ocaml/merlin#1524)
- Fix locate on module without implementation (ocaml/merlin#1522, fixes ocaml/merlin#1519)
- Allow program name customization when merlin is used as a library. (ocaml/merlin#1532)
+ editor modes
- vim: load the plugin when necessary if it wasn't loaded before (ocaml/merlin#1511)
- emacs: update CI for newer releases and fix some warnings (ocaml/merlin#1454,
@mattiase)
+ test suite
- Add tests for constructors' documentation (ocaml/merlin#1511)
- Add test cases for label comment documentation (ocaml/merlin#1526, @mheiber)
- Add a test for the `enclosing` command (ocaml/merlin#1512)
- Add tests for interactions between locate and record labels (ocaml/merlin#1505)
- Add test showing an issue with locate and implicit transitive deps
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Nov 24, 2022
CHANGES:
+ merlin binary
- Replace custom "holes" AST nodes by extensions. This restores binary
compatibility and fixes issues with PPXs when using typed-holes.
(ocaml/merlin#1503)
- Do not change temporarily Merlin's cwd when starting a PPX (ocaml/merlin#1521,
fixes ocaml/merlin#1420)
- Fix a parsing issue when declaring the `(??)` custom prefix operator.
(ocaml/merlin#1507, fixes ocaml/merlin#1506)
- Fix variant constructors' comments grouping (ocaml/merlin#1516, @mheiber, fixes ocaml/merlin#1513)
- Filter-out duplicates from the `enclosing` command result (ocaml/merlin#1512)
- Add a new `verbosity=smart` mode for type enclosing that only expand
modules' types (ocaml/merlin#1374, @ulugbekna)
- Improve locate for labels' declarations in the current buffer.
(ocaml/merlin#1505, fixes ocaml/merlin#1524)
- Fix locate on module without implementation (ocaml/merlin#1522, fixes ocaml/merlin#1519)
- Allow program name customization when merlin is used as a library. (ocaml/merlin#1532)
+ editor modes
- vim: load the plugin when necessary if it wasn't loaded before (ocaml/merlin#1511)
- emacs: update CI for newer releases and fix some warnings (ocaml/merlin#1454,
@mattiase)
+ test suite
- Add tests for constructors' documentation (ocaml/merlin#1511)
- Add test cases for label comment documentation (ocaml/merlin#1526, @mheiber)
- Add a test for the `enclosing` command (ocaml/merlin#1512)
- Add tests for interactions between locate and record labels (ocaml/merlin#1505)
- Add test showing an issue with locate and implicit transitive deps
pitag-ha
added a commit
to pitag-ha/merlin
that referenced
this pull request
Jul 25, 2023
This captures the change between the 4.14 bump and a PR fixing a locate issue, i.e. PRs ocaml#1415 ocaml#1522 Changes read from category_data.t: 2 regressions in `locate`: - Sometimes now there's a `Return Msg "didn't manage to find vertex"`, where before there was a successful return. - Same for `Return Msg "didn't manage to find Fpath"`. - Sometimes `locate` returns `Exception` now instead of `Return Msg` containing the error message. - Sometimes now there's a `Return Msg "'Unix.Unix_error' seems to originate from '_none_' whose ML file could not be found"`, where before there was a successful return. Change in `locate`: - Sometimes now there's a successrul return, where before there was `Return Msg `"didn't manage to find Key.to_hash"`. - Same for `Return Msg "Needed cmt file of module 'Info' to locate 'Info' but it is not present"`. Other changes read from full_responses.t: - module paths are reported directly, not over Dune indirective: `Irmin__Diff` -> `Diff`. - difference in location of locate - different suggestions in `complete-prefix` sometimes - probably more
pitag-ha
added a commit
to pitag-ha/merlin
that referenced
this pull request
Jul 25, 2023
This tests the fix in PR: ocaml#1522 Both, category_data.t and full_responses.t, would have caught that regression. real 12m58,120s user 2m29,301s sys 0m21,728s
pitag-ha
added a commit
to pitag-ha/merlin
that referenced
this pull request
Jul 25, 2023
Test update between the two fix PRs: ocaml#1522 https://github.com/ocaml/merlin In category_data.t: `errors` has been improved: Before it returned a list somewhere even though the code base doesn't contain errors. More in full_responses.t that I haven't looked at. real 12m22,163s user 2m19,610s sys 0m20,365s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #1519
@kate could you check if this fixes both your issues or just the first one ?