Conversation
|
@let-def , @trefis : any intuition regarding the CI failure ? Only happening on --- a/../../../default/tests/test-dirs/document/src-documentation.t/run.t
+++ b/tests/test-dirs/document/src-documentation.t/run.t.corrected
@@ -43,6 +43,9 @@ documentation for the non-last defined value (in the same file) is show
" List reversal. "
$ dune build --root=. ./doc.exe
+ ocamlopt doc.exe
+ /usr/bin/ld: .doc.eobjs/native/doc.o: warning: relocation in read-only section `.text'
+ /usr/bin/ld: warning: creating DT_TEXTREL in a PIE |
This is a 32-bit system, right? See ocaml/ocaml#9800 |
|
Oh right, that must be it ! |
|
I will review again today, but it already looked good last time I looked. |
Thank you ! For the failing test I guess we can just disable it with |
let-def
left a comment
There was a problem hiding this comment.
As far as I am concerned, the PR could be merged as is.
I suggest a few cosmetic changes that could simplify maintenance, but nothing important.
|
Friendly ping. Is there anything left to do here? It would be nice to have an official release for 4.13. Thanks! |
We plan to submit the PR to opam repository before the end of the week! |
CI tweak Fix ocaml version in workflow Fix setup ocaml config Tweak the tweaks Use correct compiler name Co-authored-by: Kate <kit.ty.kate@disroot.org> Use beta repository Co-authored-by: Kate <kit.ty.kate@disroot.org>
The test updates between the following two PRs: ocaml#1329 ocaml#1397 There seems to have been an error regression in [locate] between those two commits. That can be seen both in the category_data.json and in the full_responses.json. real 15m27,573s user 3m5,058s sys 0m20,955s
This is the change right after the 4.13 bump, i.e. PR ocaml#1397 There seems to have been an error regression in occurrences (see category_data.t): Sometimes it returns an Empty return now, where before it returned a value. Also, [complete-prefix] has changed (see full_response.t): Sometimes it adds more options now, e.g. ["name": "acosh"] and ["name": "asinh"] somewhere. Also, type aliases now seem to be handled differently sometimes (see full_response.t): e.g. [Path.t] -> [path]; [P.Contents.value] -> [contents]; [inode_tree] -> [proof_inode] etc Also, the Typedtree bump is of course reflected in Merlin, e.g. - [('a, 'b, 'c, 'd, 'e, 'f) Camlinternal FormatBasics.format6] is now [('a, 'b, 'c, 'd, 'e, 'f) format] Also, this commit contains some noise that shouldn't be there, because compiler specific messages weren't filtered out yet.
This is the change between right after 4.13 bump and right before 4.14 bump, i.e. between ocaml#1397 ocaml#1415 [locate] has changed in two ways: An error regression was fixed (before [Return Msg], now [Return Other]); there's a change in behavior, where now it sometimes points to a different place than before.
@let-def I merged your changes to synchronize with 4.13.1
Did you also start reviewing the upgrade ? This new PR is the right place to make comments.