Disable failing tests on Windows#1298
Merged
voodoos merged 1 commit intoocaml:masterfrom May 11, 2021
Merged
Conversation
d1ff891 to
0083e2f
Compare
Contributor
Author
|
Remark about the PR itself: I included 3 solutions depending on how you prefer:
If you prefer 1 we could extend the dune support for |
Collaborator
|
I think I am more in favour of option 3 anyway. |
0083e2f to
8132209
Compare
This ensures that `dune runtest` works on Windows: if Windows runners are added to ocaml-ci, this will not break the build, and failures can be fixed incrementally.
8132209 to
8674d1d
Compare
voodoos
added a commit
to voodoos/merlin
that referenced
this pull request
May 19, 2021
Disable failing tests on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that
dune runtestworks on Windows: if Windows runners are added to ocaml-ci, this will not break the build, and failures can be fixed incrementally.