Skip to content

Fix test breakage#1285

Merged
trefis merged 3 commits intomasterfrom
fix-test-breakage
Mar 17, 2021
Merged

Fix test breakage#1285
trefis merged 3 commits intomasterfrom
fix-test-breakage

Conversation

@trefis
Copy link
Copy Markdown
Contributor

@trefis trefis commented Mar 17, 2021

#1276 broke two tests (and I didn't notice! 😱 ):

  • one is due to me not considering the prefix when proposing disambiguated constructors as completion candidates. This PR fixes this
  • the other is actually a very reasonable limitation of our current context detection, which is explained in the last commit. This became apparent because the typing recovery got slightly better. Before that the guessed context was "module path" which was definitely not correct. I didn't investigate why that was the case. The present result is more correct.

This PR should fix the CI! 🙏

@trefis trefis merged commit 5643f5d into master Mar 17, 2021
@trefis trefis deleted the fix-test-breakage branch March 17, 2021 17:59
@voodoos voodoos mentioned this pull request Apr 2, 2021
32 tasks
voodoos added a commit to voodoos/merlin that referenced this pull request Apr 6, 2021
Merge pull request ocaml#1285 from ocaml/fix-test-breakage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants