Add public_name to merlin libraries (upstream from ocaml-lsp)#1172
Closed
voodoos wants to merge 8 commits intoocaml:masterfrom
Closed
Add public_name to merlin libraries (upstream from ocaml-lsp)#1172voodoos wants to merge 8 commits intoocaml:masterfrom
ocaml-lsp)#1172voodoos wants to merge 8 commits intoocaml:masterfrom
Conversation
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
trefis
approved these changes
Sep 10, 2020
Member
|
Thanks for making it easier for me downstream. I hope there's other motivations for making these libraries public however. |
Contributor
None that I can think of right now, but I'd think LSP is a good enough reason, isn't it? |
Member
|
None that I can think of right now, but I'd think LSP is a good enough reason, isn't it?
It’s just as easy for me to maintain a patch separately. I’m also looking into making private vendored libraries usable by adding an appropriate dune feature.
On a related note, it would be quite nice to transition merlin’s libraries to wrapped mode.
…On Sep 11, 2020, 1:43 AM -0700, Thomas Refis ***@***.***>, wrote:
> I hope there's other motivations for making these libraries public however.
None that I can think of right now, but I'd think LSP is a good enough reason, isn't it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Hi, I am glad this PR exist! I wanted also to voice how this could drastically improve my life. I am vendoring merlin The projects I can think of which vendor merlin:
If there is anything I can do to help you, like testing if these projects still work with this PR, that'd be a pleasure :). |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ping @rgrinberg