Merged
Conversation
reloc displays the names of default libraries as they're scanned, but not other imported libraries, which was confusing. Signed-off-by: David Allsopp <david.allsopp@metastack.com>
As per GCC spec strings, if -lgcc is given, so should -lgcc_eh. Signed-off-by: David Allsopp <david.allsopp@metastack.com>
reloc maps __imp_X to _X but didn't have the reverse case, which appears to be necessary when linking C++ applications. Signed-off-by: David Allsopp <david.allsopp@metastack.com>
This was referenced Dec 16, 2017
Member
Author
|
Buried in the quite sensible refactoring in https://github.com/cygwinports/flexdll/blob/master/0.34-cygwin.patch is a change in the Cygwin default libs which is related to this, as @yselkowitz - why do you do |
|
While on other targets, |
Closed
bryphe
added a commit
to bryphe/flexdll
that referenced
this pull request
Sep 18, 2018
This was referenced Sep 19, 2018
a9e0564 to
5f1b82f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At least for mingw64! These two changes together have allowed me to link applications using the ocaml-mccs C++ stubs.
I'm reasonably confident that the change to add
-lgcc_ehis correct (because we already add-lgcc). I'm not so totally confident about the change inReloc.needed, although I am confident that this only changes the behaviour for symbols which previously would have caused linker errors.