Closed
Conversation
Collaborator
|
Thanks, this is very nice. I'm not completely sure to understand the scope of what it fixes. In particular, do we agree that it doesn't solve, in general, the problem of loading dynamic OCaml plugins, because the dynlinked code can refer to symbols in the main program (not as jump target), which could end up being too far if Windows decides to load the .dll/.cmxs far enough from the main program? Do you have specific scenario that doesn't work without the addition of the patch, but work with it? |
bryphe
added a commit
to bryphe/flexdll
that referenced
this pull request
Oct 17, 2018
* Add appveyor * Create prebuilt package.json * Update appveyor, add create-release script * Fix cache * Add NPM cache, add create-release script * Switch environment variable format * Add flexdll.h to package * Include flexdll.h in release generation * Update artifact collection * Add deploy to NPM script * Try just running publish * Fix path for writing npmrc * Remove unused npm cache * Tweak root package * Add esy build status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I said, I have created a patch to support generation of jmp thunk table. Its purpose is to avoid "target is too far" error on 64-bit platforms. Though, for universality I made it able to be utilized in 32-bit platforms as well.
I wanted to let you know that this is actually possible.
There is one minor flaw that is it will put unneeded symbols in the jmp thunk table. This will increase the size of the binary but that amount is negligible. This can be fixed later.
I suppose this also well accomodates with COMDAT. Because there arise no need to modify the object files at all. But I have not yet tested it.
So, what would you say?