Fix odoc compile transitive lib dep#9955
Merged
rgrinberg merged 2 commits intoocaml:mainfrom Feb 9, 2024
Merged
Conversation
08d6f1d to
a14b410
Compare
Signed-off-by: Jon Ludlam <jon@recoil.org>
Some transitive deps were missed in the compile phase of the doc-new target. Signed-off-by: Jon Ludlam <jon@recoil.org>
a14b410 to
323f7fa
Compare
Merged
Leonidas-from-XIV
added a commit
that referenced
this pull request
Mar 5, 2024
* doc-new: Add test for transitive deps during compile Signed-off-by: Jon Ludlam <jon@recoil.org> * doc-new: Fix missing dependencies during odoc compile Some transitive deps were missed in the compile phase of the doc-new target. Signed-off-by: Jon Ludlam <jon@recoil.org> --------- Signed-off-by: Jon Ludlam <jon@recoil.org> Co-authored-by: Jon Ludlam <jon@recoil.org>
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Mar 11, 2024
CHANGES: ### Fixed - When a directory is changed to a file, correctly remove it in subsequent `dune build` runs. (ocaml/dune#9327, fix ocaml/dune#6575, @emillon) - Fix a problem with the doc-new target where transitive dependencies were missed during compile. This leads to missing expansions in the output docs. (ocaml/dune#9955, @jonludlam) - coq: fix performance regression in coqdep unescaping (ocaml/dune#10115, fixes ocaml/dune#10088, @ejgallego, thanks to Dan Christensen for the report) - coq: memoize coqdep parsing, this will reduce build times for Coq users, in particular for those with many .v files (ocaml/dune#10116, @ejgallego, see also ocaml/dune#10088) - on Windows, use an unicode-aware version of `CreateProcess` to avoid crashes when paths contains non-ascii characters. (ocaml/dune#10212, fixes ocaml/dune#10180, @emillon)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only a problem in the doc-new target.