fix(stdune): make sure Path.drop_prefix drops path prefixes only#8965
Conversation
4600cf5 to
002b14a
Compare
4bad250 to
711a278
Compare
|
FYI the issue is affecting our own test suite since in the describe tests, when replacing |
|
@rgrinberg Why was this marked as draft? I don't think the CI errors are related, but I can do a fresh push. |
|
b/c the tests are failing |
|
Sorry @rgrinberg you are correct that the failures are relevant. I had a look and I couldn't work out how to fix melange here. I might have a look again at a later date. |
8c3838c to
c0e984b
Compare
|
@rgrinberg @anmonteiro Melange is now fixed. I was missing the case where we drop the entire path which should give just |
|
ping |
0ba1ab0 to
415b026
Compare
We add a test demonstrating that dropping the entire path as the refix in both Path.drop_prefix and Path.External.drop_prefix has a set behaviour. This is in preperation of ocaml#8965. Signed-off-by: Ali Caglayan <alizter@gmail.com>
|
@rgrinberg I've created #9363 for the extra tests I added here. |
We add a test demonstrating that dropping the entire path as the refix in both Path.drop_prefix and Path.External.drop_prefix has a set behaviour. This is in preperation of ocaml#8965. Signed-off-by: Ali Caglayan <alizter@gmail.com>
We add a test demonstrating that dropping the entire path as the refix in both Path.drop_prefix and Path.External.drop_prefix has a set behaviour. This is in preperation of #8965. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
8302859 to
decd1e2
Compare
|
@rgrinberg Sorry about those extra tests, not sure what happened with git but it resolved the conflict in a funny way causing the tests to be duplicated. Should all be fixed now. |
Fixes #8870