refactor(engine): optimize sandbox config storage#8035
Merged
Conversation
f0e663f to
3735283
Compare
snowleopard
reviewed
Jul 9, 2023
6c4eac8 to
b031433
Compare
Member
Author
|
@snowleopard should be ready now |
f1ce156 to
97cf6ec
Compare
snowleopard
reviewed
Aug 19, 2023
snowleopard
reviewed
Aug 19, 2023
snowleopard
reviewed
Aug 19, 2023
snowleopard
reviewed
Aug 19, 2023
Collaborator
snowleopard
left a comment
There was a problem hiding this comment.
Looks good but I left some suggestions/questions.
Also: have you run any benchmarks?
Member
Author
Right now the benchmarking server is broken. Once it's back up, I'll bring some numbers. |
3eb2635 to
e6794f7
Compare
Collaborator
|
@rgrinberg Benchmarking is working again, can you resurrect this? |
e6794f7 to
d2d1f12
Compare
Member
Author
|
It does reduce major and promoted words by around 0.3-0.4%. Not sure if it's worth it, I'll let @snowleopard decide. We did end up using bit_set for something else, so I will merge that at least. |
Collaborator
|
@rgrinberg |
477abce to
b4d1c9f
Compare
Member
Author
|
ping @snowleopard |
a0f0eb3 to
7d7f058
Compare
snowleopard
reviewed
Nov 6, 2023
snowleopard
approved these changes
Nov 6, 2023
Collaborator
snowleopard
left a comment
There was a problem hiding this comment.
Looks good though see one question. I haven't had time to run any benchmarks internally but it should be a small win.
We store a sandbox configuration set for every single action we create. For a large build, this can add up. Our old representation was taking 6 words to represent this. This PR changes it to use only a single word. Moreover, this new set now opaque to the GC, speeds up comparison, hashing, etc. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: 8d6ab81b-57f7-4c94-b39c-617e78e9479d -->
7d7f058 to
419127f
Compare
voodoos
pushed a commit
to voodoos/dune
that referenced
this pull request
Nov 14, 2023
We store a sandbox configuration set for every single action we create. For a large build, this can add up. Our old representation was taking 6 words to represent this. This PR changes it to use only a single word. Moreover, this new set now opaque to the GC, speeds up comparison, hashing, etc. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We store a sandbox configuration set for every single action we create.
For a large build, this can add up.
Our old representation was taking 6 words to represent this. This PR
changes it to use only a single word. Moreover, this new set now opaque
to the GC, speeds up comparison, hashing, etc.
Signed-off-by: Rudi Grinberg me@rgrinberg.com