fix(coq): pass correct flags to coqdep when building boot libs#7942
Conversation
Signed-off-by: Ali Caglayan <alizter@gmail.com>
8ba3a37 to
3c4192d
Compare
|
Thanks a lot @Alizter , will review (and hopefully merge) ASAP. |
Why not? Patch seems broken? Didn't look closely at the test cases but maybe this is due to the logic being a bit more subtle now. Even in earlier versions of the build language, we do detect the boot library that is in Does it make sense? |
|
@ejgallego feel free to takeover. It seemed to work for me. |
I see CI / Coq test suite is broken, isn't it? |
|
@ejgallego only updating thr new flags. |
|
If this is the right fix, please resurrect. |
I see a truly broken test-case and a few suspicious things, don't you? It seems that combining |
Indeed the logic is a bit more complex than what we had. Current setup should work well now. Fixes ocaml#7909 , replaces ocaml#7942 This also reverts most of d92cb2e Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
Indeed the logic is a bit more complex than what we had. Current setup should work well now. Fixes ocaml#7909 , replaces ocaml#7942 This also reverts most of d92cb2e Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
Indeed the logic is a bit more complex than what we had. Current setup should work well now. Fixes ocaml#7909 , replaces ocaml#7942 This also reverts most of d92cb2e Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
Indeed the logic is a bit more complex than what we had. Current setup should work well now. Fixes ocaml#7909 , replaces ocaml#7942 This also reverts most of d92cb2e Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
Indeed the logic is a bit more complex than what we had. Current setup should work well now. Fixes ocaml#7909 , replaces ocaml#7942 This also reverts most of d92cb2e Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
fix #7909
I've tested the reproduction in #7909 and it works. I will not add a test for this.