Merged
Conversation
Collaborator
|
@emillon I've marked this for 3.8 since it is documenting a 3.8 feature. We can discuss it at the meeting tomorrow. |
Collaborator
|
Thanks. I fixed the markup and consolidated the changelog at the end. |
emillon
approved these changes
May 17, 2023
This PR documents that users need to have a source layout that mirrors the installation layout if they want to be able to debug installed libraries with the bytecode debugger. Signed-off-by: Richard L Ford <richardlford@gmail.com>
Signed-off-by: Etienne Millon <me@emillon.org>
This was referenced May 17, 2023
emillon
added a commit
to emillon/dune
that referenced
this pull request
May 22, 2023
Change the documentation for `(map_workspace_root)` so that it matches the existing situation. See ocaml#7743 which had been incorrectly merged. Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
that referenced
this pull request
May 22, 2023
Change the documentation for `(map_workspace_root)` so that it matches the existing situation. See #7743 which had been incorrectly merged. Signed-off-by: Etienne Millon <me@emillon.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR documents that users need to have a source layout that mirrors the installation layout if they want to be able to debug installed libraries with the bytecode debugger.