Merged
Conversation
ba1fddf to
4155f39
Compare
Contributor
|
IMO that's a good patch. |
4155f39 to
2c0d471
Compare
Member
|
Looks OK, but should we set this variable for our expect, cram, and mdx rules? Otherwise, I predict that our users will run into the same problem. |
Collaborator
Author
|
Yeah this PR is solely to fix our own CI, it doesn't mark the issue as closed. We still need to address the rest of the issue. |
Member
|
Sounds good. How about we then:
|
Since ocaml#6340 we're considering `CLICOLOR_FORCE` to determine whether stderr supports color. However this changes behavior observable from the test suite, so `CLICOLOR_FORCE=1 make test` fails (this is tracked as ocaml#6607). The issue is that ocaml/setup-ocaml#631, this variable is set in the CI environment. So we disable it until the situation is fixed (and this variable does not have observable changes anymore). Signed-off-by: Etienne Millon <me@emillon.org>
Signed-off-by: Etienne Millon <me@emillon.org>
2c0d471 to
bbd2a6a
Compare
Collaborator
Author
|
OK! I'm adding the comment here and merging it to make CI green, and will add tests in a separate PR. |
moyodiallo
pushed a commit
to moyodiallo/dune
that referenced
this pull request
Dec 2, 2022
* Set CLICOLOR_FORCE=0 Since ocaml#6340 we're considering `CLICOLOR_FORCE` to determine whether stderr supports color. However this changes behavior observable from the test suite, so `CLICOLOR_FORCE=1 make test` fails (this is tracked as ocaml#6607). The issue is that ocaml/setup-ocaml#631, this variable is set in the CI environment. So we disable it until the situation is fixed (and this variable does not have observable changes anymore). Signed-off-by: Etienne Millon <me@emillon.org>
jchavarri
added a commit
to jchavarri/dune
that referenced
this pull request
Dec 5, 2022
* main: (54 commits) doc: how we write `to_dyn` and `equal` (ocaml#6621) test(cache): test output of man pages test: dune utop for (subdir ..) (ocaml#6629) refactor: improve style of utop rules (ocaml#6628) test: depend on utop (ocaml#6627) refactor(stdune): Add Appendable_list.cons (ocaml#6624) doc: tighten wording in README.md test: add a repro case for ocaml#6607 (ocaml#6612) doc: cleanup status badges in README.md (ocaml#6618) doc(README): rewrap paragraphs and cleanup links coq: more resilient config query fix: link time code gen (ocaml#6606) fix(melange): run melc ppx with merlin (ocaml#6476) feature(melange): add compile_flags (ocaml#6569) refactor: move `modules: Modules.t` from `Dune_package.Lib` to `Lib_info` (ocaml#6605) Set CLICOLOR_FORCE=0 (ocaml#6608) fix: declare deps for ccomp detection (ocaml#6610) refactor: assume Cmdliner.Arg.conv is abstract (ocaml#6609) refactor: gen_rules pattern matching (ocaml#6604) Add CI for MSVC using dkml-workflows (ocaml#6540) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #6340 we're considering
CLICOLOR_FORCEto determine whether stderr supports color. However this changes behavior observable from the test suite, soCLICOLOR_FORCE=1 make testfails (this is tracked as #6607).The issue is that ocaml/setup-ocaml#631, this variable is set in the CI environment. So we disable it until the situation is fixed (and this variable does not have observable changes anymore).