Skip to content

ocamlc-loc: correctly skip excerpts#5981

Merged
rgrinberg merged 2 commits intomainfrom
ps/rr/test_ocamlc_loc___undefined_fields_error
Jul 16, 2022
Merged

ocamlc-loc: correctly skip excerpts#5981
rgrinberg merged 2 commits intomainfrom
ps/rr/test_ocamlc_loc___undefined_fields_error

Conversation

@rgrinberg
Copy link
Copy Markdown
Member

excerpts may start with blank characters

@rgrinberg rgrinberg added this to the 3.4.0 milestone Jul 16, 2022
@rgrinberg rgrinberg requested a review from Alizter July 16, 2022 21:10
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

ps-id: D75FEDCA-AB83-4014-B485-1BA69A487B7F
excerpt lines can start with blank space

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
@rgrinberg rgrinberg force-pushed the ps/rr/test_ocamlc_loc___undefined_fields_error branch from 5c43b64 to 0604e8d Compare July 16, 2022 22:25
@rgrinberg rgrinberg merged commit eced559 into main Jul 16, 2022
emillon added a commit to emillon/opam-repository that referenced this pull request Jul 20, 2022
…ne-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info, dune-action-plugin and chrome-trace (3.4.0)

CHANGES:

- Make `dune describe` correctly handle overlapping implementations
  for virtual libraries (ocaml/dune#5971, fixes ocaml/dune#5747, @esope)

- Building the `@check` alias should make sure the libraries and executables
  don't have dependency cycles (ocaml/dune#5892, @rgrinberg)

- [ctypes] Add support for the `errno` parameter using the `errno_policy` field
  in the ctypes settings. (ocaml/dune#5827, @droyo)

- Fix `dune coq top` when it is invoked on files from a subdirectory of the
  directory containing the associated stanza (ocaml/dune#5784, fixes ocaml/dune#5552, @ejgallego,
  @rlepigre, @Alizter)

- Fix hint when an invalid module name is found. (ocaml/dune#5922, fixes ocaml/dune#5273, @emillon)

- The `(cat)` action now supports several files. (ocaml/dune#5928, fixes ocaml/dune#5795, @emillon)

- Dune no longer uses shimmed `META` files for OCaml 5.x, solely using the ones
  installed by the compiler. (ocaml/dune#5916, @dra27)

- Fix handling of the `(deps)` field in `(test)` stanzas when there is an
  `.expected` file. (ocaml/dune#5952, ocaml/dune#5951, fixes ocaml/dune#5950, @emillon)

- Ignore insignificant filesystem events. This stops RPC in watch mode from
  flashing errors on insignificant file system events such as changes in the
  `.git/` directory. (ocaml/dune#5953, @rgrinberg)

- Fix parsing more error messages emitted by the OCaml compiler. In
  particular, messages where the excerpt line number started with a blank
  character were skipped. (ocaml/dune#5981, @rgrinberg)

- env stanza: warn if some rules are ignored because they appear after a
  wildcard rule. (ocaml/dune#5898, fixes ocaml/dune#5886, @emillon)

- On Windows, XDG_CACHE_HOME is taken to be the `FOLDERID_InternetCache` if
  unset, and XDG_CONFIG_HOME and XDG_DATA_HOME are both taken to be
  `FOLDERID_LocalAppData` if unset.  (ocaml/dune#5943, fixes ocaml/dune#5808, @nojb)
@Alizter Alizter deleted the ps/rr/test_ocamlc_loc___undefined_fields_error branch November 12, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants