Closed
Conversation
Run pkg-config as a normal rule. This is both more correct and more efficient. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: fe2317d7-3490-43ec-b4f0-3fe0be19298b
Use the rules api directly to simplify the generation of rules Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
c095f6e to
dcf2e30
Compare
mbacarella
approved these changes
Jul 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces #5932
I removed uses of configurator and replaced it with native pkg-config support. This is more correct, faster, and drops an unnecessary dependency.
Additionally, I removed the layer of indirection for passing flags. This again simplifies the code.
As I've noted on discord, I think the ctypes support would benefit from living in its own stanza. There's quite a bit of duplicated logic at the moment because the field exists for executables and libraries.