Skip to content

refactor(ctypes): simplify cctx update#5932

Closed
rgrinberg wants to merge 1 commit intomainfrom
ps/rr/refactor_ctypes___simplify_cctx_update
Closed

refactor(ctypes): simplify cctx update#5932
rgrinberg wants to merge 1 commit intomainfrom
ps/rr/refactor_ctypes___simplify_cctx_update

Conversation

@rgrinberg
Copy link
Copy Markdown
Member

Signed-off-by: Rudi Grinberg me@rgrinberg.com

ps-id: fe2317d7-3490-43ec-b4f0-3fe0be19298b

@rgrinberg rgrinberg requested a review from mbacarella June 27, 2022 20:19
@rgrinberg rgrinberg force-pushed the ps/rr/refactor_ctypes___simplify_cctx_update branch from b618947 to 3ec8ccf Compare June 28, 2022 02:08
@rgrinberg
Copy link
Copy Markdown
Member Author

I changed the PR to simply remove configurator altogether. This is faster, more correct, and removes an unnecessary dependency.

Run pkg-config as a normal rule. This is both more correct and more
efficient.

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

ps-id: fe2317d7-3490-43ec-b4f0-3fe0be19298b
@rgrinberg rgrinberg force-pushed the ps/rr/refactor_ctypes___simplify_cctx_update branch from 3ec8ccf to 9c579b2 Compare June 28, 2022 02:10
@rgrinberg
Copy link
Copy Markdown
Member Author

Replaced by #5936

@rgrinberg rgrinberg closed this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant