Conversation
3e1cea1 to
58e3b30
Compare
nojb
approved these changes
Apr 19, 2022
Collaborator
nojb
left a comment
There was a problem hiding this comment.
I didn't check the commit for update-spawn.sh, but LGTM otherwise! Thanks.
This was
linked to
issues
Apr 19, 2022
imports nojb's windows fixes Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: 33181C51-CD5A-4C51-B0FE-C28512450D02
58e3b30 to
09eac98
Compare
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Apr 19, 2022
…ne-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info and dune-action-plugin (3.1.1) CHANGES: - Fix build on Cygwin. (ocaml/dune#5593, fixes 5577, @nojb) - Fix execution of `(system ..)` actions on Windows. (ocaml/dune#5593, fixes ocaml/dune#5523, @nojb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imports nojb's windows fixes